Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helm chart test for Alerts plugin #405

Merged
merged 19 commits into from
Sep 19, 2024
Merged

Add helm chart test for Alerts plugin #405

merged 19 commits into from
Sep 19, 2024

Conversation

ibakshay
Copy link
Contributor

This PR, fixes #359

@ibakshay
feat(alerts): Add test framework configuration
9ad4b4c 
- Added test-alerts-config.yaml to configure the test framework for integration tests.
- Added test-alerts.yaml to define the integration test pod.
- Added test-permissions.yaml to set up the necessary permissions for the test framework. - Updated values.yaml to enable the test framework and specify the image and pull policy.
@ibakshay
refactor(alerts): Update test configuration
07bea4a
@ibakshay
Merge branch 'main' into feature/359-create-test-alert-manager
85ad9e5
@ibakshay
Merge branch 'main' into feature/359-create-test-alert-manager
67cc999
@ibakshay
test(Alerts) Add tests
dc79067
@ibakshay
chore(alerts): cleanup test values file
e365fad
@ibakshay ibakshay requested review from a team as code owners September 19, 2024 10:27
@github-actions GitHub Actions
Copy link

⚠️ Chart oci://ghcr.io/cloudoperators/greenhouse-extensions/charts/alerts:0.12.4 already exists in OCI registry. Please increment the chart version.

@ibakshay ibakshay self-assigned this Sep 19, 2024
richardtief
richardtief requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@richardtief richardtief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks. A few comments below

alerts/ci/test-values.yaml Show resolved Hide resolved
alerts/charts/templates/tests/test-alerts-config.yaml Outdated Show resolved Hide resolved
alerts/charts/templates/tests/test-alerts-config.yaml Outdated Show resolved Hide resolved
richardtief
richardtief requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@richardtief richardtief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing.

alerts/ci/test-values.yaml Outdated Show resolved Hide resolved
richardtief
richardtief requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@richardtief richardtief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing. With tests, it is a new minor version.

alerts/charts/Chart.yaml Outdated Show resolved Hide resolved
alerts/plugindefinition.yaml Outdated Show resolved Hide resolved
alerts/plugindefinition.yaml Show resolved Hide resolved
richardtief
richardtief approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@richardtief richardtief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the tests!

@richardtief richardtief merged commit 8362624 into main Sep 19, 2024
4 checks passed
@richardtief richardtief deleted the feature/359-create-test-alert-manager branch September 19, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardtief richardtief richardtief approved these changes

Assignees

@ibakshay ibakshay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[alerts] Create chart integration tests
2 participants
@ibakshay @richardtief